[Webkit-unassigned] [Bug 62099] createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception 9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62099


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96037|review?                     |review-
               Flag|                            |




--- Comment #5 from Jeremy Orlow <jorlow at chromium.org>  2011-06-04 15:56:54 PST ---
(From update of attachment 96037)
View in context: https://bugs.webkit.org/attachment.cgi?id=96037&action=review

Looks pretty good.

> Source/WebCore/dom/PopStateEvent.cpp:34
> +PopStateEvent::PopStateEvent()

You need to call Event's consturctor and initialize m_stateObject

> Source/WebCore/dom/PopStateEvent.h:40
> +    static PassRefPtr<PopStateEvent> create()

Would slightly prefer these factory methods being moved inside the .cpp

> Source/WebCore/dom/PopStateEvent.h:54
> +protected:

Does anythign sub-class this?  If not, put it inside "private:"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.