[Webkit-unassigned] [Bug 61878] Smooth scrolling for Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61878





--- Comment #27 from Vangelis Kokkevis <vangelis at chromium.org>  2011-06-03 22:34:52 PST ---
(From update of attachment 95985)
View in context: https://bugs.webkit.org/attachment.cgi?id=95985&action=review

> Source/WebCore/page/FrameView.cpp:2243
> +bool FrameView::scrollAnimatorEnabled() const

Are the changes to the FrameView still needed?

>>> Source/WebCore/platform/ScrollableArea.h:142
>>> +    virtual bool scrollAnimatorEnabled() const { return false; }
>> 
>> this doesn't seem like a property of a ScrollableArea.  Do we ever intend to have the scroll animator on for some ScrollableAreas but off for others?
> 
> In the long run, no. This is for the short term while things are under development, in order to leave them behind a run-time flag. This was the simplest path for ScrollAnimator to reach up and get the flag from Settings. Is there a preferred way to do that?

I don't see an easy way for the ScrollableArea to reach to the page Settings either...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.