[Webkit-unassigned] [Bug 61878] Smooth scrolling for Chromium
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 3 11:55:57 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=61878
--- Comment #19 from Vangelis Kokkevis <vangelis at chromium.org> 2011-06-03 11:55:57 PST ---
(In reply to comment #18)
> > If you could give me a quick pointer at an example you think would fit, and I'll get things cleaned up. I'm going to be working in WebKit more moving forward, so now is a good time to teach me.
>
> I don't really understand what this code is all about, so it's difficult to give you good advice. ChromeClient.h might make sense given that ChromeClient deals with UI stuff. (Note the "Chrome" in ChromeClient refers to "browser chrome" not "the browser named Chrome.")
>
> Really, you should find a reviewer who both understands how WebKit fits together and understands what you're trying to do.
Using ChromeClient seems like a good idea. We already use it for some other settings related to compositing.
In the interest of making this check-in more manageable and since the current scroll settings are hardwired, would it make sense to embed the settings in the ScrollAnimatorChromium class and separate them out in a subsequent CL when we figure out who needs to adjust them an how?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list