[Webkit-unassigned] [Bug 61946] FrameLoaderClient::didRunInsecureContent - no way to distinguish between blocked/run cases.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61946





--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-06-03 11:36:21 PST ---
(From update of attachment 95926)
View in context: https://bugs.webkit.org/attachment.cgi?id=95926&action=review

> Source/WebCore/loader/EmptyClients.h:371
> +    virtual void didBlockDisplayingInsecureContent() { }
> +    virtual void didBlockRunningInsecureContent() { }

We probably want the offending URL, right?  Also, for didBlockRunningInsecureContent we probably want the SecurityOrigin, as in the did run case.

> Source/WebCore/loader/FrameLoader.cpp:1125
> +        m_client->didDisplayInsecureContent();
> +    } else
> +        m_client->didBlockDisplayingInsecureContent();

One thing we discussed is whether we should combine these into one call.  Another question is whether we should call back into the client to make the final "go/no-go" decision, like we do for allowPlugins.  That gives the client maximum flexibility.  It can use the Setting to provide a default, but can still tweak things on a load-by-load basis if needed.  Also, the client then knows whether the load was blocked because it makes the final decision.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.