[Webkit-unassigned] [Bug 60059] AssociatedURLLoader reports some errors synchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60059


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95791|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #13 from Adam Barth <abarth at webkit.org>  2011-06-03 10:45:45 PST ---
(From update of attachment 95791)
View in context: https://bugs.webkit.org/attachment.cgi?id=95791&action=review

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:89
> +    OwnPtr<Timer<ClientAdapter> > m_errorTimer;

This should just be a regular member, not an OwnPtr.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:190
> +void AssociatedURLLoader::ClientAdapter::notifyError(Timer<ClientAdapter>* timer)

You should assert that |timer| has the value you expect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.