[Webkit-unassigned] [Bug 61799] Fix LayoutTests/canvas/suite/tests/2d.text.measure.width.space.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 08:48:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61799





--- Comment #7 from Philip Rogers <pdr at google.com>  2011-06-03 08:48:45 PST ---
Created an attachment (id=95919)
 --> (https://bugs.webkit.org/attachment.cgi?id=95919&action=review)
Adds replaceHTMLWhiteSpace and call it in drawText as well as measureText, which makes us pass 5 of Philip's canvas tests

>From my reading of the spec, it looks like white space should not be collapsed (meaning the tests are wrong and my patch was wrong), but please hold off on an actual review until it's confirmed. I updated this patch to reflect the reviewer comments and have a more optimized conversion step from html white space characters to ' '. I also temporarily used simplifyWhiteSpace() to do the collapsing.

When I get a response on this message (http://lists.w3.org/Archives/Public/public-canvas-api/2011AprJun/0037.html), I'll update this bug with the final patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list