[Webkit-unassigned] [Bug 61631] Add ENABLE(REGIONS) guard for CSS Regions support

Fri Jun 3 06:51:36 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61631

--- Comment #5 from Mihnea Ovidenie <mihnea at adobe.com>  2011-06-03 06:51:36 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > I used ENABLE(REGIONS) since this was the original guard in our work. 
> 
> It makes no sense for WebKit community.
> 

Ok, you know better.

> > While looking over the FeatureDefines.xcconfig files, i was not able to find out any defines using 'CSS' or 'LAYOUT' in their names.
> 
> That menas we have no other flags for CSS or layout.
> 
> We have ENABLE_SVG_USE.  Do you think it's ok to name it ENABLE_USE if no other SVG flags?

Good point. In this case, i vote for ENABLE_CSS_REGIONS. Should i rewrite the patch to use ENABLE_CSS_REGIONS and post a new version of the patch? Are you going to review it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.