[Webkit-unassigned] [Bug 56855] [GTK] Provide a way in DRT to check the platform name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56855


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95894|                            |review?
               Flag|                            |




--- Comment #17 from Mario Sanchez Prada <msanchez at igalia.com>  2011-06-03 05:16:11 PST ---
Created an attachment (id=95894)
 --> (https://bugs.webkit.org/attachment.cgi?id=95894&action=review)
Patch proposal + Layout test

(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > [...]
> > > I still think we should have a layout test to test this, otherwise we might 
> > > find out that this doesn't work before we get to use it
> > 
> > Ok, although I must admit I do not have a clue about where under LayoutTests to place a test like this... any suggestion?
> 
> I think sticking one in accessibility is fine

Sounds good to me, specially taking into account that perhaps accessibility tests will be the only ones that will be using it, in the short term at least.

Actually, after thinking a little bit about this suggestion of putting it under accessibility/ I thought that it could be a good idea also, based on the same reasoning, to provide this feature only to the platforms that would be using it, that is, mac, win and gtk (after all, there's no point in adding code to platforms that never will use it). 

As a result, I dropped from this new patch all the code related to implementing this new function in chromium, qt and wx platforms, and secured the changes in the toplevel LayoutTestController.[cpp|h] files through #ifdef guards.

Also, provided expectations to other ports apart from Gtk, that is, win and mac.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.