[Webkit-unassigned] [Bug 61272] [Chromium] On-the-spot IME support for windowless plug-ins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61272





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2011-06-02 21:16:12 PST ---
(From update of attachment 95420)
View in context: https://bugs.webkit.org/attachment.cgi?id=95420&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1394
> +        String pluginText = text;
> +        pluginText.append('\n');
> +        pluginText += String::number(selectionStart);
> +        pluginText.append('\n');
> +        pluginText += String::number(selectionEnd);
> +        pluginText.append('\n');
> +        for (size_t i = 0; i < underlines.size(); ++i) {
> +            pluginText += String::number(underlines[i].startOffset);
> +            pluginText.append('\n');
> +            pluginText += String::number(underlines[i].endOffset);
> +            pluginText.append('\n');
> +            pluginText += String::number(underlines[i].color);
> +            pluginText.append('\n');
> +            pluginText.append(underlines[i].thick ? '1' : '0');
> +            pluginText.append('\n');
> +        }

We had better use wtf/text/StringBuilder.

> LayoutTests/platform/chromium/test_expectations.txt:4036
> +
> +// We need a Chromium-side change to fix this test.
> +BUGCR82507 : platform/chromium-win/plugins/windowless-plugin-ime-event-test.html = TEXT

I recommend adding lines not at the bottom of test_expectations.txt in order to avoid patch conflicts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.