[Webkit-unassigned] [Bug 61878] Smooth scrolling for Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61878


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95843|review?                     |review-
               Flag|                            |




--- Comment #13 from Adam Barth <abarth at webkit.org>  2011-06-02 18:28:02 PST ---
(From update of attachment 95843)
View in context: https://bugs.webkit.org/attachment.cgi?id=95843&action=review

The structure of this patch makes very little sense.  I recommend splitting off the settings part because that's going to require a very different kind of review than the guts of the algorithm.

> Source/WebCore/page/FrameView.h:340
> +    virtual const ScrollAnimatorSettings* scrollAnimatorSettings() const;

const ScrollAnimatorSettings* => ScrollAnimatorSettings const*  right?

> Source/WebCore/platform/ScrollAnimatorSettings.h:44
> +class ScrollAnimatorSettings {
> +public:
> +    static PassOwnPtr<ScrollAnimatorSettings> create();
> +
> +    virtual void setEnableScrollAnimator(bool flag) { }
> +    virtual bool scrollAnimatorEnabled() const { return false; }
> +};

This seems like way overkill.  Is this supposed to be a client?  This isn't how we do settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.