[Webkit-unassigned] [Bug 61878] Smooth scrolling for Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61878


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org




--- Comment #10 from Adam Barth <abarth at webkit.org>  2011-06-02 15:01:40 PST ---
(In reply to comment #9)
> (In reply to comment #6)
> > (From update of attachment 95781 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=95781&action=review
> > 
> > > Source/WebCore/platform/chromium/ScrollAnimatorSettings.cpp:42
> > > +static ScrollAnimatorSettings& globalScrollAnimatorSettings()
> > > +{
> > > +    DEFINE_STATIC_LOCAL(ScrollAnimatorSettings, settings, ());
> > > +    return settings;
> > > +}
> > 
> > Why is this a static?  Should this be part of WebCore::Settings?  It seems like a per-Page concept.
> 
> Looking through things, I'm thinking that the right way to do that is for ScrollableArea to have a routine which gets the settings, which FrameView overrides to provide them from the Page. Does that make sense?

That's a reasonable design.  I don't know enough context to understand the issue fully, but the state should be attached to the object graph somewhere.  :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.