[Webkit-unassigned] [Bug 61555] Chromium doesn't implement WebCore::MediaPlayer::mediaTimeForTimeValue()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 12:35:13 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61555





--- Comment #15 from Aaron Colwell <acolwell at chromium.org>  2011-06-02 12:35:13 PST ---
(In reply to comment #14)
> (From update of attachment 95618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95618&action=review
> 
> > Source/WebKit/chromium/public/WebMediaPlayer.h:138
> > +    virtual float mediaTimeForTimeValue(float timeValue) const = 0;
> 
> How about mediaTimeFromTimeValue?
> "For" sounds odd.

I was just copying the method name from Source/WebCore/platform/graphics/MediaPlayerPrivate.h . Is it worth changing the method name at this middle layer or do you want me to change it all the way up and down the stack?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list