[Webkit-unassigned] [Bug 58191] Use console.log() instead of alert() in unload handlers in tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58191





--- Comment #11 from Ojan Vafai <ojan at chromium.org>  2011-06-02 11:43:56 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > Once bug 56397 is committed, these tests can't be run manually for the Chromium port since the alert won't fire. Maybe one solution to bug 56397 would be to make alerts still log when fired during unload in layout test mode. That essentially gets the same behavior as this patch while leaving the tests manually testable on non-chromium ports.
> 
> But that would make these tests not manually testable on Chromium (or any other port that decides to disallow alerts), right?  Given that we want to eventually disallow alerts in all ports, that doesn't seem like a great solution.

Do you have a suggestion for how to make these tests manually testable once bug 56397 is fixed? I don't see a good way to accomplish that and it's unfortunate that bug 56397 is now blocked on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.