[Webkit-unassigned] [Bug 61946] New: FrameLoaderClient::didRunInsecureContent - no way to distinguish between blocked/run cases.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 2 11:31:05 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=61946
Summary: FrameLoaderClient::didRunInsecureContent - no way to
distinguish between blocked/run cases.
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: UNCONFIRMED
Severity: Normal
Priority: P2
Component: Frames
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: tsepez at chromium.org
CC: abarth at webkit.org
FrameLoader::checkIfRunInsecureContent() calls m_client->didRunInsecureContent with the same arguments in both the case where the insecure content was actually run, and in the case where it is blocked from running by security policy. There needs to be a way to distinguish the two cases so that clients can create appropriate notifications.
Note that FrameLoader::checkIfDisplayInsecurContent() has the same issue with its call to m_client->didDisplayInsecureContent().
A good solution would be to add didBlockRunningInsecureContent() and didBlockDisplayingInsecureContent() methods, and call one or the other, thus restoring the meaning of the original methods. Adding a flag seems less desirable since the name of the existing method is now misleading and would more accurately be called "didEncounterInsecureContent()".
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list