[Webkit-unassigned] [Bug 60059] AssociatedURLLoader reports some errors synchronously

Thu Jun 2 11:22:51 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60059

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92131|review?                     |review-
               Flag|                            |

--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-06-02 11:22:51 PST ---
(From update of attachment 92131)
View in context: https://bugs.webkit.org/attachment.cgi?id=92131&action=review

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:185
> +        m_errorTimer = new Timer<ClientAdapter>(this, &ClientAdapter::notifyError);

WebKit frowns upon "naked new", meaning calls to new should immediately be followed by either adoptPtr or adoptRef, as appropriate.  In any case, we just normally make these Timer objects be regular members, not pointers.  Actually, I'm surprised this patch even compiles.  There must be something wrong somwhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.