[Webkit-unassigned] [Bug 48290] Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 10:34:30 PDT 2011


--- Comment #14 from Matthew Delaney <mdelaney at apple.com>  2011-06-02 10:34:30 PST ---
(In reply to comment #13)
> (In reply to comment #10)
> > (From update of attachment 95655 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=95655&action=review
> > 
> > > Source/WebCore/ChangeLog:13
> > > +        Tests: No new tests required. 
> > > +        LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.
> > 
> > I don’t understand why this patch doesn’t include new passing test results for that test.
> I could not completely understand the above. The test case is already existing in WebKit repo, therefore I did not add any test case. Where should I include the test result?

If this change makes all ports pass this test, then you should remove the test from all ports' Skipped lists. For example, one such Skipped list is at LayoutTests/platform/mac/Skipped. I checked and this test is on that skipped list, and thus won't be run.

It's also best to remove any expected failing results files under LayoutTests/platform for all ports that may have been running the test before (i.e. not on their Skipped lists) but expecting it to fail.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list