[Webkit-unassigned] [Bug 61865] [Qt] Implement download feature for QtTestBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61865


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95752|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2011-06-02 06:32:27 PST ---
(From update of attachment 95752)
View in context: https://bugs.webkit.org/attachment.cgi?id=95752&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:53
>      , m_zoomAnimation(0)
> +    , m_reply(0)
>  {

Please update this part of the patch, because it conflicts with ToT.

> Tools/QtTestBrowser/launcherwindow.cpp:940
> +    connect(m_reply, SIGNAL(finished()), this, SLOT(slotFinished()));

I can't find slotFinished anywhere, but fileDownloadFinished.

> Tools/QtTestBrowser/launcherwindow.cpp:950
> +    if (fileName.isEmpty() || !m_reply->errorString().isNull())
> +        QMessageBox::warning(this, QString("Download"), QString("Download failed."));

It fails for me, m_reply->errorString() returns always with "Unknown error."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.