[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 03:11:53 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61915


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-06-02 03:11:53 PST ---
Attachment 95745 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Last 3072 characters of output:
dentifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:178:  _ewk_view_on_mouse_move is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:178:  event_info is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:187:  _ewk_view_on_key_down is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:187:  event_info is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:196:  _ewk_view_on_key_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:196:  event_info is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:205:  _parent_sc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:217:  _ewk_view_priv_del is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:225:  _ewk_view_smart_add is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:266:  _ewk_view_smart_del is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:275:  _ewk_view_smart_resize is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:287:  _ewk_view_smart_move is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:294:  _ewk_view_smart_calculate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:319:  _ewk_view_smart_show is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:327:  _ewk_view_smart_hide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:334:  ewk_view_smart_set is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:386:  ewk_view_add is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:404:  ewk_view_page_get is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 41 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list