[Webkit-unassigned] [Bug 56855] [GTK] Provide a way in DRT to check the platform name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56855





--- Comment #14 from chris fleizach <cfleizach at apple.com>  2011-06-01 14:41:08 PST ---
(In reply to comment #13)
> Created an attachment (id=95452)
 --> (https://bugs.webkit.org/attachment.cgi?id=95452&action=review) [details]
> Patch proposal
> 
> (In reply to comment #12)
> > (From update of attachment 88635 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=88635&action=review
> > 
> > You should add a test that shows this is working. 
> 
> Well I haven't done it since it's a patch for a new functionality in DRT, not in WebKit, so I thought it wouldn't be needed since its functionality would be tested anytime it was used in a LayoutTest :-)
> 

I still think we should have a layout test to test this, otherwise we might find out that this doesn't work before we get to use it


> > You should also explain why this is needed.
> 
> See comment #8 and comment #10. It's all in there :-)
> 
> > > Tools/DumpRenderTree/LayoutTestController.cpp:2093
> > > +    return JSValueMakeString(context, controller->platformName());
> > 
> > This is leaking the JSStringRef returned by platformName. platformName should return a JSRetainPtr<JSStringRef> instead.
> 
> Thanks for the catch. Attaching a new patch fixing these issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.