[Webkit-unassigned] [Bug 49045] LayoutTests/svg/animations/animate-path-nested-transforms.html causes assertion in debug mode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49045





--- Comment #12 from Rob Buis <rwlbuis at gmail.com>  2011-06-01 14:33:39 PST ---
I think I know what goes wrong. First, the id value in the expected values is wrong for this test. That causes a change in this code section:

(SMILTimeContainer::updateAnimations):

            SVGElement* targetElement = animation->targetElement();
            // FIXME: This should probably be using getIdAttribute instead of idForStyleResolution.
            if (!targetElement || !targetElement->hasID() || targetElement->idForStyleResolution() != m_nextSamplingTarget)
                continue;

            samplingDiff = animation->intervalBegin();

Because these tests are only started on click, and intervalBegin() in that case is small but not 0, it is important for the later code calling progress to take this into account. Again, this is caused by a wrong id value in the expected results, as m_nextSamplingTarget will mismatch.
For now I propose to just fix the tests. The only alternative I can think of is to give a warning or even assert when the id is not found at all?
Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.