[Webkit-unassigned] [Bug 61858] [GTK] run-launcher should run MiniBrowser in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61858


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95594|review?                     |review+
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-06-01 08:43:38 PST ---
(From update of attachment 95594)
View in context: https://bugs.webkit.org/attachment.cgi?id=95594&action=review

>>> Tools/Scripts/run-launcher:72
>>> +            @args = @ARGV;
>> 
>> Why is it necessary to preserve "-2" here? I ask because Qt does not do this.
> 
> I guess the Qt program ignores options that it doesn't handle, MiniBrowser returns with an error because -2 option is invalid. I added this, because I wasn't sure, so I wanted to make sure I didn't break other ports.

Ah, I see. I misunderstood the comment. You might consider expanding it to something like: "isWK2() removes the -2 option from @ARGV, but not @args. We do not want to pass -2 to MiniBrowser."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.