[Webkit-unassigned] [Bug 7275] window.getSelection() doesn't work in textareas

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 04:46:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=7275


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rniwa at webkit.org,
                   |                            |xan.lopez at gmail.com




--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2011-06-01 04:46:48 PST ---
FWIW, I recently stumbled upon this bug and I think nowadays we do what comment #1 (from 2006!) says Firefox used to do back then. The thing that makes this fail is DOMSelection.cpp:getRangeAt, which has a chunk like:


    if (Node* shadowAncestor = selectionShadowAncestor(m_frame)) {
        ContainerNode* container = shadowAncestor->parentNodeGuaranteedHostFree();
        int offset = shadowAncestor->nodeIndex();
        return Range::create(shadowAncestor->document(), container, offset, container, offset);
    }

triggered inside text areas (and that makes us return a 0-0 bogus range). If I just *remove* that code, my simple tests seem to work OK, but I'm sure that breaks something else somewhere.

Opinions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list