[Webkit-unassigned] [Bug 48290] Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 01:37:30 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=48290


sarapkarthik <sarap.karthik at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sarap.karthik at gmail.com




--- Comment #1 from sarapkarthik <sarap.karthik at gmail.com>  2011-06-01 01:37:30 PST ---
    I was going through the bug https://bugs.webkit.org/show_bug.cgi?id=48290, which passes is FF but fails in Safari/Winlauncher( r87771)

As per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing, "highlight" is NOT a valid composite operation. but it is being mentioned in platform/graphics/GraphicsTypes.cpp in compositeOperatorNames[] & that's why this issue is present.

When I removed "highlight" from here & also removed "CompositeHighLight  from enum CompositeOperator in GraphicsType.h this issue is resolved (I also had to comment out all other code using CompositeHighLight    & CSSValueHighlight.

However, the following comment was mentioned in GraphicsType.h ("    // Note: These constants exactly match the NSCompositeOperator constants of
    // AppKit on Mac OS X Tiger. If these ever change, we'll need to change the
    // Mac OS X Tiger platform code to map one to the other. "). So I am little unclear what is the purpose of this CompositeHighLight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list