[Webkit-unassigned] [Bug 61825] Change the Page Visibility attribute names as per the spec

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 01:33:01 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61825


Tony Gentilcore <tonyg at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95521|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Tony Gentilcore <tonyg at chromium.org>  2011-06-01 01:33:01 PST ---
(From update of attachment 95521)
View in context: https://bugs.webkit.org/attachment.cgi?id=95521&action=review

Please update the ChangeLog, everything else looks good.

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=61825

In the bug, you mention:
1. The event needs to be webkitVisibilityChange from webkitVisibilityStateChange
2. The attribute webkitIsVisible needs to change to webkitHidden

That sort of description should always go in the ChangeLog. Also, if available, a link to the spec update would be nice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list