[Webkit-unassigned] [Bug 65096] New: [CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 24 23:50:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65096

           Summary: [CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when
                    parsing -webkit-wrap-shape
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: achicu at adobe.com


Fix for the feedback in comment #30 From Luke Macpherson on https://bugs.webkit.org/show_bug.cgi?id=61726 .

(From update of attachment 99531 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=99531&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:5314
> +        if (isInitial) {

remove this whole if and use the HANDLE_INHERIT_AND_INITIAL(wrapShape, WrapShape) instead.

> Source/WebCore/css/CSSStyleSelector.cpp:5318
> +        

if (!primitiveValue) return; here, and remove the later checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list