[Webkit-unassigned] [Bug 60673] <input type=number> doesn't ignore size="" attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60673





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2011-07-31 23:13:18 PST ---
(From update of attachment 102434)
View in context: https://bugs.webkit.org/attachment.cgi?id=102434&action=review

> LayoutTests/ChangeLog:10
> +
> +        * fast/forms/input-number-size-expected.txt: Added.
> +        * fast/forms/input-number-size.html: Added.
> +

I think we need to update some others tests in fast/forms/.

> Source/WebCore/ChangeLog:8
> +        The input[type=number] element should be as wide as necessary to show the widest possible value.
> +        https://bugs.webkit.org/show_bug.cgi?id=60673
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/forms/input-number-size.html

You should explain behaviors which the patch will introduce.

> Source/WebCore/html/NumberInputType.cpp:358
> +    if (element()->renderStyle() && !element()->renderStyle()->width().isUndefined())
> +        return true;

!element()->renderStyle()->width().isAuto() is probably what you want.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.