[Webkit-unassigned] [Bug 58013] [Chromium] Needs eventSender.scalePageBy()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58013


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102370|review?                     |review-
               Flag|                            |




--- Comment #5 from Kent Tamura <tkent at chromium.org>  2011-07-31 19:24:48 PST ---
(From update of attachment 102370)
View in context: https://bugs.webkit.org/attachment.cgi?id=102370&action=review

> LayoutTests/ChangeLog:21
> +        * platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
> +        * platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
> +        * platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
> +        * platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
> +        * platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
> +        * platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
> +        * platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Removed.
> +        * platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
> +        * platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Removed.
> +        * platform/chromium/test_expectations.txt: Enabled three tests.

It seems we need new expectation files for the followings on chromium-mac and chromium-win.

compositing/scaling/tiled-layer-recursion.txt
repaint/scale-page-shrink.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-client-rect.html

Removing wrong expectations is ok, but removing entries in test_expectations.txt wil break the tests because of lack of correct expectations.

> Source/WebKit/chromium/public/WebView.h:209
> +    // Page scaling --------------------------------------------------------
> +
> +    // Scales a page by a factor of scaleFactor and then sets a scroll position to (x, y).
> +    virtual void scalePageBy(float scaleFactor, float x, float y) = 0;

Changing public interface only for DumpRenderTree should be avoided.
Can you move EventSender.scalePageBy() to window.internals.scalePageBy() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.