[Webkit-unassigned] [Bug 65438] JSC GC is far too conservative about growing the heap size, particularly on desktop platforms

Sun Jul 31 15:52:49 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65438

--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2011-07-31 15:52:49 PST ---
(In reply to comment #2)
> (From update of attachment 102467 [details])
> I don't like the mac-specificness of this.  I also don't really like the magic numbers (2 * .., 3 * ...) and the compile time constant for criticalBytes could be problematic on systems with less physical ram

2 * heapsize was there before.  Would you recommend changing these to be named constants?

As for the 128MB: before, if we had a 128MB heap we would have set the watermark at 256MB.  Now we'll set it at 384MB.  What do you think of this approach: base the GC heap size growth factor on the FastMalloc reserved pages count?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.