[Webkit-unassigned] [Bug 55455] [EFL] HTML saving feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55455





--- Comment #30 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-07-30 20:42:51 PST ---
(From update of attachment 97413)
View in context: https://bugs.webkit.org/attachment.cgi?id=97413&action=review

LGTM except for my comments.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1983
> + *      must @b not be @c 0, this value @b should be freed after use

Move start of must to start of frame_source below.

> Source/WebKit/efl/ewk/ewk_frame.cpp:2000
> +        // FIXME Support others documents.

Missing ":" in FIXME.

> Source/WebKit/efl/ewk/ewk_frame.cpp:2048
> + *   the Eina_List should be freed after use

wrong indentation. Move the Eina_List to @c below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.