[Webkit-unassigned] [Bug 65382] The JSC garbage collector returns memory to the operating system too eagerly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65382





--- Comment #8 from Oliver Hunt <oliver at apple.com>  2011-07-30 19:18:26 PST ---
(From update of attachment 102448)
View in context: https://bugs.webkit.org/attachment.cgi?id=102448&action=review

Not r+/r- because i don't understand why this doesn't lead to the main thread blocking on the release-thread

> Source/JavaScriptCore/heap/Heap.cpp:319
> +    MutexLocker locker(m_freeBlockLock);

Do we really want to wait while holding the freeBlock lock?  It looks like that would lead to allocateBlock blocking for up to a second on this secondary thread?

> Source/JavaScriptCore/heap/Heap.h:39
> +#if ENABLE(SINGLE_THREADED)
> +#define HEAP_FREE_BLOCKS_EAGERLY 1
> +#else
> +#define HEAP_FREE_BLOCKS_EAGERLY 0
> +#endif

I think this would read better in general if this became WTF_ENABLE_EAGER_BLOCK_FREEING, and then the call sites work can be guarded with ENABLE(EAGER_BLOCK_FREEING) which is our more typical approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.