[Webkit-unassigned] [Bug 65344] Make external URL references work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 30 09:12:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65344





--- Comment #1 from Rob Buis <rwlbuis at gmail.com>  2011-07-30 09:12:33 PST ---
Keeping this as a reminder for this bug:

> > Source/WebCore/css/SVGCSSStyleSelector.cpp:396
> > -            svgstyle->setMarkerEndResource(SVGURIReference::getTarget(s));
> > +            svgstyle->setMarkerEndResource(SVGURIReference::fragmentIdentifierFromIRIString(s, m_element->document()));
> 
> Oops, we silently assume same-document references here! If we just extract the fragment identifier here, we're going to ignore any external URL.
> We should store the whole IRI string here, and lookup the targetelmenetForIRIString later in rendering/ when we actually use the marker end resource.
> 
> That affects all usages of fragmentIdentifierFromIRIString - thery're all assuming same-doc refs, which is wrong.
> (Parts from our IRC discussion)

Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list