[Webkit-unassigned] [Bug 65397] LayoutTests does not have a test for array speculation pathologies in the JavaScriptCore DFG JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65397


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102404|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-07-29 18:06:36 PST ---
(From update of attachment 102404)
View in context: https://bugs.webkit.org/attachment.cgi?id=102404&action=review

> LayoutTests/fast/js/array-type-speculation-expected.txt:6
> +PASS result is "foo"

When possible, it's better to construct the test so that you can see what is being tested in the test output. Just seeing "result" is not so great. One way to do that is to make sure that the argument to shouldBe itself contains arguments that make it clear which test is which.

But I know that with JavaScript testing it can be tricky to achieve that since different ways of executing code exercise different code paths.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.