[Webkit-unassigned] [Bug 59064] [GTK] Support EGL backend for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59064





--- Comment #9 from Kenneth Russell <kbr at google.com>  2011-07-29 14:55:45 PST ---
(From update of attachment 101722)
View in context: https://bugs.webkit.org/attachment.cgi?id=101722&action=review

The #ifdefs added throughout GraphicsContext3DOpenGL.cpp are going to be poor to maintain. I think a better way to do this would be to move most of the code from GraphicsContext3DOpenGL.cpp into a GraphicsContext3DOpenGLBase.cpp. In those routines where different behavior is needed, define implementations of the methods in GraphicsContext3DOpenGL.cpp and for example GraphicsContext3DOpenGLES.cpp.

See for example Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp and Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp .

I'm refraining from touching the review bit in case others have differing opinions, since Chromium doesn't actually use this code.

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:94
> +#if USE(EGL)
> +    ::glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
> +    ::glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
> +#else
>      ::glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP);
>      ::glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP);
> +#endif

GL_CLAMP_TO_EDGE should be used in both cases.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1587
> +    if (type == GL_FLOAT)
> +        return false; // Not supported in GLES 2.0

If the GL_OES_texture_float extension is available, then this would be supported.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.