[Webkit-unassigned] [Bug 65362] Search field in designMode causes a crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 29 14:12:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65362





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-07-29 14:12:02 PST ---
I talked with Dimitri and Levi and we agreed that the correct approach here is not to propagate designMode=true into the shadow DOM.

So this crash can be fixed by one line change:
--- Source/WebCore/dom/Node.cpp    (revision 92006)
+++ Source/WebCore/dom/Node.cpp    (working copy)
@@ -781,7 +781,7 @@

 bool Node::rendererIsEditable(EditableLevel editableLevel) const
 {
-    if (document()->frame() && document()->frame()->page() && document()->frame()->page()->isEditable())
+    if (document()->frame() && document()->frame()->page() && document()->frame()->page()->isEditable() && !shadowTreeRootNode())
         return true;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list