[Webkit-unassigned] [Bug 65353] Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65353


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102322|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-07-29 10:50:05 PST ---
(From update of attachment 102322)
View in context: https://bugs.webkit.org/attachment.cgi?id=102322&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1983
>>                  if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
>>                      $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
>>                  } else {
>> -                    $requiresAllArguments = "Raise";
>> +                    $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || "Raise";
>>                  }
> 
> There is probably a cleaner way to write this that doesn’t repeat the expression function->signature->extendedAttributes->{"RequiresAllArguments"}.

I would just address this comment.  It's easy to fix.  :)

> Source/WebCore/page/DOMWindow.idl:205
> -        [EnabledAtRuntime=FileSystem] void webkitRequestFileSystem(in unsigned short type, in long long size, in [Callback, Optional] FileSystemCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
> -        [EnabledAtRuntime=FileSystem] void webkitResolveLocalFileSystemURL(in DOMString url, in [Callback, Optional] EntryCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
> +        [EnabledAtRuntime=FileSystem] void webkitRequestFileSystem(in [Optional=CallWithDefaultValue] unsigned short type, 
> +                                                                   in [Optional=CallWithDefaultValue] long long size, 
> +                                                                   in [Callback, Optional] FileSystemCallback successCallback, 
> +                                                                   in [Callback, Optional] ErrorCallback errorCallback);
> +        [EnabledAtRuntime=FileSystem] void webkitResolveLocalFileSystemURL(in [Optional=CallWithDefaultValue] DOMString url, 
> +                                                                           in [Callback, Optional] EntryCallback successCallback, 
> +                                                                           in [Callback, Optional] ErrorCallback errorCallback);

I'd skip these.  FileSystem is pretty new.

> Source/WebCore/page/DOMWindow.idl:250
>  #if defined(ENABLE_REQUEST_ANIMATION_FRAME)
>          // WebKit animation extensions
>          long webkitRequestAnimationFrame(in [Callback] RequestAnimationFrameCallback callback, in Element element);
> -        void webkitCancelRequestAnimationFrame(in long id);
> +        void webkitCancelRequestAnimationFrame(in [Optional=CallWithDefaultValue] long id);
>  #endif

This API is already pretty new.  I'd skip it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.