[Webkit-unassigned] [Bug 65376] New: Split RenderBlock::layoutRunsAndFloats into multiple methods
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 29 07:19:34 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65376
Summary: Split RenderBlock::layoutRunsAndFloats into multiple
methods
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: UNCONFIRMED
Severity: Normal
Priority: P2
Component: Layout and Rendering
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: achicu at adobe.com
RenderBlock::layoutRunsAndFloats has a couple of different parts:
1. Determines the first dirty line
2. Detaches the lines starting from the first dirty line
3. Finds the last dirty line
4. Computes the lines starting with the first dirty lines. Also tries to match the last line, or at least somewhere near that.
5. If the last line was matched it links it with the new generated lines.
6. Fix floats after the last line.
7. Repaint some floats that needed repaint during layout
Steps 1, 2, 3 are extracted into separate methods, but 4 and 5 are quite long and still part of RenderBlock::layoutRunsAndFloats.
This patch should extract 4, 5-6 and 7 into 3 separate methods.
It should also help fix bug https://bugs.webkit.org/show_bug.cgi?id=61303, which triggers a position change for a float changes in steps 5 and 6. That happens when doing multi-column incremental layout and the floats have to move from one column to another. It should be much easier to repeat steps from 3 to 6 if it is required to do so.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list