[Webkit-unassigned] [Bug 65353] Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65353





--- Comment #2 from Darin Adler <darin at apple.com>  2011-07-28 18:59:46 PST ---
(From update of attachment 102322)
View in context: https://bugs.webkit.org/attachment.cgi?id=102322&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1983
>                  if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
>                      $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
>                  } else {
> -                    $requiresAllArguments = "Raise";
> +                    $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || "Raise";
>                  }

There is probably a cleaner way to write this that doesn’t repeat the expression function->signature->extendedAttributes->{"RequiresAllArguments"}.

> Source/WebCore/page/DOMWindow.idl:74
> +        [Custom] DOMWindow open(in [Optional=CallWithDefaultValue] DOMString url,

I’m curious, what does “call with default value” mean? What is the default value?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.