[Webkit-unassigned] [Bug 62175] [GTK] Implement monotonicallyIncreasingClock()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62175


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101659|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-07-28 10:17:11 PST ---
(From update of attachment 101659)
View in context: https://bugs.webkit.org/attachment.cgi?id=101659&action=review

This looks sane to me.

> Source/JavaScriptCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * wtf/CurrentTime.cpp:
> +        (WTF::monotonicallyIncreasingTime):

Please fill in this ChangeLog, explaining how the existing implementation of monotonicallyIncreasingTime can fail.

> Source/JavaScriptCore/wtf/CurrentTime.cpp:313
> +#elif PLATFORM(GTK)

I think it would be better to use #if ENABLE(GLIB_SUPPORT) here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.