[Webkit-unassigned] [Bug 65302] [EFL] Modify type of both col and row parameters for backing store's internal api.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65302





--- Comment #4 from KwangHyuk <hyuki.kim at samsung.com>  2011-07-28 05:27:08 PST ---
First of all, thank you for your review,


> The data types were changed from _ewk_tiled_backing_store_item_add upwards, but you also need to check which data is passed to it as well (by quickly skimming through the file I can see some long to unsigned int conversions done before item_add is called, for example), so that it is verified that no useless casts are done or whether other data types should be changed. _ewk_tiled_backing_store_view_cols_end_add (which calls item_add) and _ewk_tiled_backing_store_recalc_renderers (which calls end_add) are good starting points.

I agree with you. In order to reduce the type conversions, tiled_matrix and callers data type are better to be changed.
So, I will generate new patch for it soon.

In addition, as you know, eina_matrixsparse is now using unsigned long type for both col and row parameter, so, I am thinking that ewk is also better to use same parameter type for col and row.


> Extra space after "and".
Fixed.

> From what I see, the changes made were fairly obvious, so this paragraph should not be needed.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.