[Webkit-unassigned] [Bug 65302] [EFL] Modify type of both col and row parameters for backing store's internal api.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65302





--- Comment #2 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-28 05:00:42 PST ---
IMO the patch needs further investigation.

The data types were changed from _ewk_tiled_backing_store_item_add upwards, but you also need to check which data is passed to it as well (by quickly skimming through the file I can see some long to unsigned int conversions done before item_add is called, for example), so that it is verified that no useless casts are done or whether other data types should be changed. _ewk_tiled_backing_store_view_cols_end_add (which calls item_add) and _ewk_tiled_backing_store_recalc_renderers (which calls end_add) are good starting points.

> Source/WebKit/efl/ChangeLog:7
> +        and  ewk_tiled_backing_store_item_add are different from each other, I modify type of them.

Extra space after "and".

> Source/WebKit/efl/ChangeLog:9
> +        some related lines of those parameters are modified.

>From what I see, the changes made were fairly obvious, so this paragraph should not be needed. If you did some changes which were not obvious, it'd be better to mention them below in each function in the ChangeLog instead of here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.