[Webkit-unassigned] [Bug 65084] Build without video but fullscreen API is broken

Thu Jul 28 03:51:02 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65084

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102133|review?                     |review-
               Flag|                            |

--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2011-07-28 03:51:02 PST ---
(From update of attachment 102133)
View in context: https://bugs.webkit.org/attachment.cgi?id=102133&action=review

Almost there, thanks again for the patch!

> Source/WebCore/ChangeLog:3
> +        This fixes build without video enabled. Bug 65084.

You need to have 2 lines, one for the bug description and the second line containing the link to the bug.
prepare-ChangeLog --bug 65084 can be used too :)

> Source/WebCore/dom/EventDispatcher.cpp:9
> + * Copyright (C) 2011 Denis Oliver Kropp (dok at directfb.org)

According to our contributor policy only substantive code changes allow a copyright update. This patch is quite small, so please remove this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.