[Webkit-unassigned] [Bug 64259] [EFL] Implement EditorClientEfl::respondToChangedContents

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 22:42:40 PDT 2011


--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-07-27 22:42:40 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > Given he's already given an r+, I think you could also leave it as-is.
> > 
> > I think this is not big work. Why don't we fix antonio's comment before landing this patch ? 
> > 
> > Michal,
> > 
> > Could you update this patch based on comment #10 ? Please fill review field in ChangeLog as below,
> > 
> > Reviewed by NOBODY (OOPS!). => Reviewed by Antonio Gomes.
> > 
> > Then, please request only cq.
> I am bit confused... I know that is not a big work, but I want to get Antonio's confirmation first. Anyway until then I am leaving it as it is.

Antonio already gave r+. But, he pointed minor problem in this patch. So, if you fix it, AFAIK, you don't need to get r+ again. But, frankly, I am not sure if this fix is minor problem. If you think it is better to get r+ from Antonio again, please request r?/cq? again when you submit updated patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list