[Webkit-unassigned] [Bug 64689] [CSSRegions]Add basic RenderRegion support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64689


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101977|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Dave Hyatt <hyatt at apple.com>  2011-07-27 09:19:15 PST ---
(From update of attachment 101977)
View in context: https://bugs.webkit.org/attachment.cgi?id=101977&action=review

r=me

> Source/WebCore/rendering/RenderRegion.cpp:59
> +void RenderRegion::layout()
> +{
> +    ASSERT(needsLayout());
> +
> +    computeLogicalWidth();
> +    computeLogicalHeight();
> +
> +    setNeedsLayout(false);
> +}

This is interesting. I wonder if there should be an intrinsic size for regions or not. I know this is being debated in the CSS WG. I suggested they have no intrinsic size (and that is what you've done here), but I know others would like them to maybe be more like iframes or objects (300x150 intrinsic size). I guess for now we can just stick with 0x0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.