[Webkit-unassigned] [Bug 62684] Regression: font-size: 100% may cause ruby text to overlap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62684


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102092|review?                     |review-
               Flag|                            |




--- Comment #3 from mitz at webkit.org  2011-07-26 20:44:57 PST ---
(From update of attachment 102092)
View in context: https://bugs.webkit.org/attachment.cgi?id=102092&action=review

This bug is about the overlap, but the patch changes other things. Most notably, it allows greater overhang (more than half a ruby) in some cases. If you want to change the maximum amount of overhang allowed, file a separate bug and explain why you want to change that. The current implementation follows the example in <http://www.w3.org/TR/2009/NOTE-jlreq-20090604/#en-subheading2_3_6>.

> Source/WebCore/rendering/RenderRubyRun.cpp:298
> +    int logicalLeftOverhang = 0;
> +    if (startRenderer && startRenderer->isText())
> +        logicalLeftOverhang = min<int>(toRenderText(startRenderer)->minLogicalWidth(), startRenderer->style(firstLine)->fontSize()) / 2;
> +    int logicalRightOverhang = 0;
> +    if (endRenderer && endRenderer->isText())
> +        logicalRightOverhang = min<int>(toRenderText(endRenderer)->minLogicalWidth(), endRenderer->style(firstLine)->fontSize()) / 2;

Why is it okay to set the logical left overhang based on the startRenderer regardless of writing direction?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.