[Webkit-unassigned] [Bug 62852] cannot handle status codes which have no response body

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 19:18:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62852





--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-07-26 19:18:44 PST ---
(From update of attachment 102090)
View in context: https://bugs.webkit.org/attachment.cgi?id=102090&action=review

> Source/WebCore/loader/FrameLoader.cpp:3299
> +    m_delegateIsFinishingWithoutBody = true;
> +    m_client->dispatchDidFinishLoadingWithoutBody(dl);
> +    m_delegateIsFinishingWithoutBody = false;

Frown.  We use this pattern a bunch in FrameLoader, but it's really fragile.  If we're being re-entered by the client, who's to say this function can't be re-entered?  The net result of patches like this are that we have skads of these bools hanging off FrameLoader and the class is a bear to work with.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list