[Webkit-unassigned] [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64897


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101933|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #22 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-07-26 15:49:51 PST ---
(From update of attachment 101933)
View in context: https://bugs.webkit.org/attachment.cgi?id=101933&action=review

yeah, this is basically what i had in mind.  one more round.

> Source/WebKit/chromium/public/WebPopupMenu.h:44
> +    // Sets the minimum height of a popup listbox row.

nit: new line above this comment.

> Source/WebKit/chromium/public/WebPopupMenu.h:45
> +    WEBKIT_API static void setPopupListBoxMinimumRowHeight(int);

nit: no need to repeat the word Popup.  i'd probably just name this method setMinimumRowHeight since it should be obvious that this could only refer to the rows of the popup menu.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.