[Webkit-unassigned] [Bug 65171] CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65171


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102034|review?                     |review-
               Flag|                            |




--- Comment #6 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-26 12:05:58 PST ---
(From update of attachment 102034)
View in context: https://bugs.webkit.org/attachment.cgi?id=102034&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:728
> +        if isinstance(features, list) == False:

Better WebKit style would be:

if not isinstance(features, list):

We don't have this kind of checking for other parts of config.json. Why is this attribute special?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:729
> +            raise Exception, "Builder %r: 'features' parameter needs to be a list of flags that will be passed to build-webkit script. eg. features: ['css-regions']" % builder['name']

I think the more modern way to do this is using constructor syntax: raise Exception("Builder %r:...")

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.