[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #87 from Adam Barth <abarth at webkit.org>  2011-07-26 11:18:12 PST ---
> 2-  Disable performing the default action for synthetic events.

^^^ It's unclear to me what sort of compatibility risk this change would incur.  Whether we want to make that change globally throughout the project is a separate question from what we do with this patch.

The correct way to implement (2) is to change when HTMLAnchorElement::defaultEventHandler is called, not do donk around with the "is synthetic" bool.  Changing when HTMLAnchorElement::defaultEventHandler is called will change both the link following and the downloading behavior simultaneously, which means if we tried to implement that restriction this patch we'd either

1) face the compat risk of changing how dispatchEvent works for following hyperlinks, or
2) need to used a hacky implementation of the restriction other than changing when HTMLAnchorElement::defaultEventHandler is called.

Neither of those alternatives is appealing.  Therefore, we should proceed with this patch as-is and then decide whether to implement (2) globally.  Once we make that decision, we can implement it correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.