[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-07-26 08:14:24 PST ---
(From update of attachment 101997)
View in context: https://bugs.webkit.org/attachment.cgi?id=101997&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:220
> +    GOwnPtr<GdkEvent> inputEvent(gdk_event_copy(event.nativeEvent()));
> +    gtk_main_do_event(inputEvent.get());

I think we shouldn't copy the event, gtk_main_do_event() doesn't modify the event.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:-60
> -struct _WebKitWebViewBasePrivate {
> -    OwnPtr<PageClientImpl> pageClient;
> -    RefPtr<WebPageProxy> pageProxy;
> -    gboolean isPageActive;
> -    GtkIMContext* imContext;
> -    GtkClickCounter clickCounter;
> -    CString tooltipText;
> -};
> -

I prefer to keep private structures as private and add specific private API when needed, it makes easier to know who and why is using the private members outside the object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.