[Webkit-unassigned] [Bug 63531] Turn PreloadScanner implementation to a thread based solution

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63531





--- Comment #28 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-07-26 07:27:47 PST ---
Attachment 101999 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/html/parser/CSSPreloadScanner.cpp:202:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:6:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:9:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:12:  "HTMLPreloadScanner.h" already included at Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:5  [build/include] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:13:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:26:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:91:  Missing space before ( in while(  [whitespace/parens] [5]
Source/WebCore/html/parser/HTMLPreloadScannerThread.cpp:104:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.h:8:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.h:11:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/html/parser/HTMLPreloadScannerThread.h:33:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 11 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.